[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gEDA-dev: [PATCH] gschem: recent files support
On Monday 23 April 2007 12:02:20 Ivan Stankovic wrote:
> On Sat, Apr 21, 2007 at 11:23:40AM +0100, Peter Clifton wrote:
> > My strategy for dealing with the guile stuff is to find a similar thing
> > I want to copy, then use grep to chase it through the various places it
> > is implemented.
> >
> > Good luck, and great work on the patch so far.
>
> Thanks for the help, I appreciate it. Please see the new patch
> attached.
Firstly, big problem: you're using GLib's key file API, which was introduced
in GLib 2.6. Gschem is required to be backward compatible as far as 2.4.
Options:
1. Check for GTK 2.6, and don't support recent files if the API isn't new
enough (easy solution).
2. Use a different mechanism (good solution).
Secondly, since gschem loads configuration from the current working directory,
that would be the appropriate place to store the recent files list. This has
the added advantage that all the files in the recent files list would be
relevant to the project you're currently working on.
Thirdly, I like using Stacked Git and my CVS-cloned repo at
http://repo.or.cz/w/geda-gaf.git to manage my ongoing patches. It provides
lots of tools for managing multiple sets of patches and for browsing history.
gitk is your friend!
Finally, keep up the good work! It always takes a while to get your head
around the idiosyncrasies of a project when you're a new developer. Please
don't get disheartened by the criticisms.
Cheers,
Peter
--
Fisher Society committee http://tinyurl.com/o39w2
CUSBC novices, match and league secretary http://tinyurl.com/mwrc9
CU Spaceflight http://tinyurl.com/ognu2
v3sw6YChw7$ln3pr6$ck3ma8u7+Lw3+2m0l7Ci6e4+8t4Gb8en6g6Pa2Xs5Mr4p4
hackerkey.com peter-b.co.uk
PGP signature
_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev