Re: gEDA-dev: [PATCH] gschem: remember dialog size and position

[Peter Clifton <pcjc2-at-NOSPAMcam_dot_ac_dot_uk>]

On Tue, 2007-05-01 at 11:16 +0200, Ivan Stankovic wrote:
> On Mon, Apr 30, 2007 at 10:29:39PM +0100, Peter Clifton wrote:
> > I'd not inline the functions - they don't appear to be called in a
> > performance critical path. Also, they might be useful outside the
> > x_dialog.c code?
> 
> Perhaps, I didn't spend much time thinking of it.
> The functions are only inlined if glib is older that 2.6.0 in which
> case there's no point in wasting either time or space.

Ok, I'm not sure myself what the use-cases are for the inline keyword.
Does the compiler usually decide inline / normal functions when
optimising?

Does anyone have any advice / info on usage of the inline keyword. DJ?

It it possible to inline a function in one C file, and have the linker
correctly inline it where called from other files, or does it have to be
within the same source file?

[snip]

> Yes, this is the way to go.  However, I have no desire to dive into the
> glib object system.  If you (or anyone else) could come up with a GschemDialog 
> or GedaDialog, I would be very happy to modify all of x_dialog.c to use
> that.  In this light, I see my patch only as a temporary solution, something
> that's usable until we get our own dialog widget that will handle all 
> resizing and positioning automatically.

Assuming any people more knowledgeable than myself about best-practise
GTK agree that a subclass of GtkDialog is the way to go, I'll write an
implementation next week. It shouldn't be very long or complex.

The main point requiring thought is where to tell the new class about
Gschem, and/or is config file. It might just need a new construct time
parameter when we create instances.

> > We'd want the functionality for the main window probably too, so I guess
> > you can just call the same set size hooks on that manually.
> 
> Sure.  Thanks for the comments!

No problem, I'm glad to see the great patches!

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev