Re: gEDA-dev: GschemDialog finally works!

[Peter Clifton <pcjc2-at-NOSPAMcam_dot_ac_dot_uk>]

On Sun, 2007-05-20 at 23:49 +0200, Ivan Stankovic wrote:
> On Sat, May 19, 2007 at 05:26:46PM -0400, Stuart Brorson wrote:
> > > I just confirmed it is a bug in my patch and am working on a fix.
> > > Thanks for reporting!
> > 
> >  Good news!  I eagerly await the new patch!
> 
> Alright, here it is. It was a one line fix.
> 
> Peter, I would really appreciate if you could review the
> patch and remove things like '#if 0' and some other commented
> code since I'm not sure what it does or if it will be needed.
> As for the comments, I don't think there is much work needed,
> the functions in gschem_dialog.c are pretty much self explanatory,
> but what I feel missing is perhaps a paragraph about creating new
> dialogs with GschemDialog as a base. Other than that, I am very
> positive about this patch.

I should have some time to do this towards the end of next week. Until
then I've got quite a few meetings to prepare for. I look forward to the
code going into CVS, and will of course help with the review and
commenting GschemDialog.

Peter




_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev