Re: gEDA-dev: [PATCH] gschem: Visual feedback for keyboard commands

[Peter TB Brett <peter-at-NOSPAMpeter-b_dot_co_dot_uk>]

On Thursday 31 May 2007 19:07:51 Ivan Stankovic wrote:
> Let me give an example; if you press 'f', the string displayed
> will be just 'f' and it will stay displayed until you press
> another key. Assume then you press 'w'. Then the 'w' will be
> appended to the string and 'fw' will be displayed in the
> status bar for 400ms. After that the string is cleared.
> (The string is also cleared any time you press Escape.)


+gchar *current_keyaccel_string = NULL;
+static TOPLEVEL *saved_toplevel = NULL;

...

+  /* We need to save the toplevel because it may not be
+   * there anymore when we need to clear the status bar string
+   * (this occurs with the 'fc' command, for example) */
+  saved_toplevel = global_window_current;


This is a hack.  I know the model-view-controller separation in gschem is 
pretty rubbish, but there must be a better way to handle this without making 
the situation even worse than it is already.  The phrase "maintenance 
nightmare" comes to mind.

Peter


-- 
Fisher Society                              http://tinyurl.com/o39w2
CU Small-Bore Club                          http://tinyurl.com/mwrc9

      09f911029d74e35bd84156c5635688c0            peter-b.co.uk

PGP signature

_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev