Re: gEDA-dev: [PATCH] gschem: Visual feedback for keyboard commands

["Ales Hvezda" <ahvezda-at-NOSPAMgmail_dot_com>]

Hi,

> Because, I really don't know how to solve this (yes, I tried, very
> hard, but the resulting code was _very_ complicated which is what
> I'm trying to avoid here). Maybe I'm just dumb.

I'll take a more detailed look at the patch tonight and give my two
cents on the current behavior.

On a slightly different topic...

I've been noticing that some of the code cleanup patches have been changing:

if (...) {
  single_statement;
}

to:

if (...)
  single_statement;

Please, please, please don't go out of your way to make such changes.
I have discovered (through lots of pain maintaining other people's
code) that those brackets improve code clarity and help convey
programmer intent.  Yes, it is a stylistic choice/nit/whatever, but
once you bitten by the

if (...)
   statement1;
   statement2;

oops, you might change your mind.  Thanks,

-Ales


_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev