[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gEDA-dev: [PATCH] gschem: Visual feedback for keyboard commands



Hi Ivan,

[snip]
>The patch below should implement this. Note that I'm not very happy

I got a chance to play with your patch and I like this feature quite a
bit.

>with the behaviour, and this patch certainly isn't for CVS. 
>For example, see what happens when you press the return key several
>times. It floods the entire status bar with a 'ReturnReturn..." string.
>
>Would a static global counter be acceptable to solve this problem? :)

	I don't know if Peter's guile callback suggestion will solve
this problem, but it is something to consider.

	And you might consider limiting the key name text to a fixed
number of characters (say 10-15).  If the allocation of characters
fills up (or you cannot display the entire keyname), clear it, and then
add more.

								-Ales

PS. About the use of static variables, be careful, the user can open up
multiple windows and I just observed the same key name string in two
different toplevel windows (when I only typed it in one of them).



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev