Re: gEDA-dev: [PATCH] gschem: Visual feedback for keyboard commands

[Dan McMahill <dan-at-NOSPAMmcmahill_dot_net>]

Peter Clifton wrote:
> On Fri, 2007-06-08 at 11:53 +0100, Peter Clifton wrote:
>> On Thu, 2007-06-07 at 23:02 -0400, Ales Hvezda wrote:
> 
>> Could this be a guile 1.8 change? I read somewhere that "nil" should not
>> be used, and depending on context, either #f or () was appropriate.
>>
>> We should fix all other cases if there are any.
> 
> grep nil * -r --include "*.scm"
> 
> gnetlist/scheme/gnet-cascade.scm:              (sourcenet nil)
> gnetlist/scheme/gnet-cascade.scm:       nil
> gnetlist/scheme/gnet-cascade.scm:           (first_block nil)
> gnetlist/scheme/gnet-pcbpins.scm:               (label nil)
> gnetlist/scheme/gnet-pcbpins.scm:               (pinnum nil)
> gschem/scheme/pcb.scm:  (let ((f nil))
> gschem/scheme/pcb.scm:  (let ((f def nil))
> 
> It would be good if people familiar with these scripts could fix them. I
> could probably make a stab at it, but wouldn't know immediately how to
> test them - and be sure the bug had gone.

doh!  These are all mine :(

I'll make sure we have a regression test in place for the first 2 files
and get rid of nil.  The pcb.scm one, I'll get rid of the nil.  I have 
to get guile-1.8.1 working for me first though.

-Dan



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev