Re: gEDA-dev: [PATCH] gschem: Visual feedback for keyboard commands

[Carlos Nieves Ónega <cnieves_dot_mail-at-NOSPAMgmail_dot_com>]

El vie, 08-06-2007 a las 11:53 +0100, Peter Clifton escribió:
> On Thu, 2007-06-07 at 23:02 -0400, Ales Hvezda wrote:
> 
> > On an unrelated note (your patch does not affect this), pressing "g" or
> > some other key bound to "no-action" causes gschem to immediately exit 
> > with: 
> > 
> > ERROR: Unbound variable: nil
> > 
> > Anybody have any ideas on this breakage?  Has it always done this?  
> > Anybody out there with an old version, try pressing "g"; ideally nothing
> > should happen (ie no unexpected exits).  Thanks,
> 
> GAH! So it does! Thats horrid!
> 
> The fix is:
> 
> diff --git a/gschem/scheme/gschem.scm b/gschem/scheme/gschem.scm
> index 748f0cb..42e28cd 100644
> --- a/gschem/scheme/gschem.scm
> +++ b/gschem/scheme/gschem.scm
> @@ -31,7 +31,7 @@
>  ; no action hotkey
>  (define no-action
>    (lambda ()
> -      nil 
> +    #f
>    )
>  )
> 
> 
> Could this be a guile 1.8 change? I read somewhere that "nil" should not
> be used, and depending on context, either #f or () was appropriate.
> 
> We should fix all other cases if there are any.
> 
> I've not time to commit this right now, so if anyone else wants to, go
> right ahead - with a suitable changelog.

Patch applied. Thanks.
Dan, I'll let you fix the other files.

Regards,

Carlos



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev