[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gEDA-dev: [PATCH] gschem: remove unused code
On Wed, 2007-06-27 at 16:27 +0200, Ivan Stankovic wrote:
> This patch removes most of the unused code from gschem. Please review.
> I would also appreciate if original authors would check the remaining
> pieces that are still unused. Running git grep '#if 0' with
> my patch applied gives:
>
> src/g_hook.c:#if 0
> src/o_copy.c:#if 0
> src/o_copy.c:#if 0
> src/o_copy.c:#if 0
> src/x_image.c:#if 0
>
> ---
> gschem/include/globals.h | 16 ------
> gschem/src/a_zoom.c | 37 -------------
> gschem/src/g_keys.c | 9 ---
> gschem/src/g_rc.c | 105 ------------------------------------
> gschem/src/g_register.c | 4 --
> gschem/src/i_callbacks.c | 40 --------------
> gschem/src/o_attrib.c | 6 --
> gschem/src/o_basic.c | 12 ----
> gschem/src/o_bus.c | 132 ----------------------------------------------
> gschem/src/o_complex.c | 38 -------------
> gschem/src/o_cue.c | 3 -
> gschem/src/o_grips.c | 7 +--
> gschem/src/o_misc.c | 13 -----
> gschem/src/o_net.c | 129 --------------------------------------------
> gschem/src/o_pin.c | 5 --
> gschem/src/o_select.c | 14 -----
> gschem/src/o_slot.c | 11 ----
> gschem/src/o_text.c | 30 ----------
> gschem/src/x_basic.c | 43 ---------------
> gschem/src/x_dialog.c | 22 --------
> gschem/src/x_event.c | 14 -----
> gschem/src/x_grid.c | 10 ----
> gschem/src/x_stroke.c | 8 ---
> gschem/src/x_window.c | 10 ----
> 24 files changed, 1 insertions(+), 717 deletions(-)
Nice patch... nice ;)
I've not had time to test it, but I just love the diffstat!
--
Peter Clifton
Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA
Tel: +44 (0)7729 980173 - (No signal in the lab!)
_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev