Re: gEDA-dev: Ivan's gattrib patches

[Peter Clifton <pcjc2-at-NOSPAMcam_dot_ac_dot_uk>]

On Wed, 2007-08-01 at 23:39 +0200, Ivan Stankovic wrote:
> On Wed, Aug 01, 2007 at 10:01:33PM +0100, Peter Clifton wrote:
> > I'd imagine File->Open would close the files you have open right now,
> > and then allow you to open a new one (or multiple).
> 
> Yes, that's the plan.
> 
> > Ivan - could you take a quick look at the git repo at:
> > http://repo.or.cz/w/geda-gaf/pcjc2.git
> > and see if you're still happy with the patches (and my odd change here
> > and there).
> 
> I looked at it and it wasn't pretty; I had to manually apply,
> commit and then 'stg assimilate' each and every patch.  :(

Sorry - I assumed you'd be able to clone from the repo, and export the
patches with git-format patch.

> It would have been far better if you just added your changes on top
> of my patches unchanged -- regardless the program state between
> individual patches. But there's no point in doing that now.
> So please push them to the repo.

IMO, the main benefit of using stgit is allowing you to fix things like
this immediately, before pushing to the repo. Sure, if mistakes happen
and you push a patch with a bug to the repo, the only way to fix it is
to push another on top - but for clarity, and the ability to
successfully git-bisect to find a bug, its pretty important we don't
introduce bugs too often.

> > Also - what are your thoughts with regards the set_cell function, and
> > possibly removing the rest of that related code. (Or leaving it all?)
> 
> Just leave it for Stuart to decide, it won't hurt. I left it on
> purpose when I was removing most of the code around it.

I'll await his decision. I think the other patches still apply without
that one, so I can push the rest.

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev