[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

gEDA-dev: Bug fix for embedded pictures not working

Hi Ales,

You might want to cherry-pick:

commit 1f336cc81195dadaffd4bbec17e8a40950b7935b
Author: Peter Clifton <pcjc2@cam.ac.uk>
Date:   Wed Sep 5 18:47:23 2007 +0100

    Simplify test to call gdk_init() in o_read_picture()
    
    Avoids testing a GtkWidget pointer in TOPLEVEL variable setup by gschem or
    gattrib. Instead, just ensure we call gdk_init() at least once. If gschem
    or gattrib already did, its not a problem as repeated calls aren't harmful.


I was trying to test my refactoring of the picture code, and noticed
embedded pictures didn't work. Due to reading off the end of a memory
buffer, the bug(s) could cause a segfault due to invalid reads.

Regards,

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev