Re: gEDA-dev: CRITICAL error when canceling move mode?

[Peter Clifton <pcjc2-at-NOSPAMcam_dot_ac_dot_uk>]

On Sun, 2008-11-16 at 19:31 -0500, Ales Hvezda wrote:
> Hi,
> 
> You will get the following message to stdout:
> 
> ** (gschem:4217): CRITICAL **: o_drawbounding: assertion `o_glist != NULL' 
> failed
> 
> if you do the following:
> 
> 1) select an object
> 2) Press "m" (for move mode)
> 3) Click the right mouse button to cancel.
> 
> Is this a critical error, a plain error, or not an error at all?

Its not a critical error, someone probably got over-zelous with the type
of macro used to check it.

Since a glist of NULL is just the empty list, it is almost certain that
the code _would_ work fine without that critical error message, it would
just be a NOP.

This is probably (although I've not looked) caused by the cancel
clearing out the selection list, but somewhere along the code-path, a
drawing function gets called to paint / unpaint / move the rubberbanded
version of the selection.

I'll dig into this when I get chance, thanks for the instructions to
reproduce. The fixes might be:

1. Remove the unnecessary error / warning.


2. Audit the code-path which this gets called from, as it certainly
isn't useful to attempt a drawing operation after we emptied the
selection list. If it is something which happens incidentally, there is
no harm in leaving it. If it is explicit, we ought to remove the
ineffective call.

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev