Re: gEDA-dev: CRITICAL error when canceling move mode?

[Peter Clifton <pcjc2-at-NOSPAMcam_dot_ac_dot_uk>]

On Mon, 2008-11-17 at 00:37 +0000, Peter Clifton wrote:
> On Sun, 2008-11-16 at 19:31 -0500, Ales Hvezda wrote:

> > ** (gschem:4217): CRITICAL **: o_drawbounding: assertion `o_glist !=
> NULL' failed

[snip]

> > Is this a critical error, a plain error, or not an error at all?
> 
> Its not a critical error, someone probably got over-zelous with the type
> of macro used to check it.

PS.. that person was me ;). I can't remember why I changed this to an
error, but I expect it was part of some code-audit of the rendering
code-paths:

commit b74ce15668b87380fb348a94aab6452eba6f5551
Author: Peter Clifton <pcjc2@cam.ac.uk>
Date:   Sat Sep 27 22:58:09 2008 +0100

    Use g_return_if_fail to exit o_drawbounding() if called with a NULL list.
    
    Function previously returned silently, lets log this as an error
    condition if it should happen.

[snip]

> Since a glist of NULL is just the empty list, it is almost certain that
> the code _would_ work fine without that critical error message, it would
> just be a NOP.
> 
> This is probably (although I've not looked) caused by the cancel
> clearing out the selection list, but somewhere along the code-path, a
> drawing function gets called to paint / unpaint / move the rubberbanded
> version of the selection.
> 
> I'll dig into this when I get chance, thanks for the instructions to
> reproduce. The fixes might be:
> 
> 1. Remove the unnecessary error / warning.
> 
> 2. Audit the code-path which this gets called from, as it certainly
> isn't useful to attempt a drawing operation after we emptied the
> selection list. If it is something which happens incidentally, there is
> no harm in leaving it. If it is explicit, we ought to remove the
> ineffective call.

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev