Re: Calling all beta testers! -- Re: gEDA: Big changes to RC file system

[sdb-at-NOSPAMcloud9_dot_net (Stuart Brorson)]

Patrick --

> I have reviewed your code and I have found some problems, mainly
> memory related. I have only checked libgeda and gschem. A diff against
> each of these packages is attached.

Thanks for the patches.  I have applied them on two machines, and they
work fine on both.  I will upload them to CVS tomorrow.

I belive that the majority of your submitted stuff involved replacing
my homegrown functions with GTK functions, right?  Thanks for doing
this!  I am not that familiar with all the featured offered by
GTK. . . .

> BTW you should take the opportunity to document your changes directly
> in the texinfo parts of the noweb files.  You should also avoid adding
> C comments in these documentation parts (the /* --- */ lines before
> the @sections).

I am completely happy to move comments into the texinfo header in each
function.  However, the reason I use the /* --- */ is to be able to
distinguish easily between one function section and the next.   This
helps me find my way through the code.  

So, I guess my question is:  is there an accepted way to put
this type of delimiters into noweb source?  If the noweb processors
just throws this stuff away, what's wrong with it?

> I have not extensively tested, only reviewed the code.

Test it & let me know if you think the operation is more user-friendly
now.  

Stuart