Re: gEDA-dev: gschem modifications

[Ales Hvezda <ahvezda-at-NOSPAMseul_dot_org>]

Hi Peter,


[snip]
>I'd appreciate advice on better working practices, as to seperate out my
>changes, I now need to checkout the new CVS, make a diff between that
>and my work (after cleaning the build files (.o etc) out), then sort out
>the chances which I have made, so I can then end up with a patch for
>each group of new functionality / changed behaviour I've been working
>on.

	Yes, this is definately preferable, as it is far far far easier
for me to look at a patch that adds one feature.  I tend not to like
monster patches since they are far hard to understand and verify.

[snip]

> * Added option to allow mouse panning on middle mouse button, as well
>as RH button.

	A change like this will most likely need to be configurable.	

>
> * Changed pan "gain" to 1, rather than 5, so when panning with the
>mouse, the schematic page moves as if you had actually grabbed the page
>at the point when you start panning from

	I'd be interested in playing with this change.

>
> * (Hardcoded), scroll wheel behaviour to zoom in/out, with LEFT/RIGHT,
>UP/DOWN with a "shift" / "control" modifier
>
> * Slightly modified the preview widget / event handler code to allow
>mouse scroll zooming with the same event handler as the main schematic
>view
>
>We now have a gschem, where the mouse scroll wheel is able to zoom, pan
>by dragging, and pan LR / UD by scrolling with modifier keys - basically
>making it a navigation button / wheel.


	This too might want to be configurable.  Another possibility is 
to toss some of the configurability and just pick something and see
what happens.  A benefit of this is that it is (I think?) more compatible
with PCB.


>
>Re-layed out component picker:
>-----------------------------
>
> * Eventually, I would like to see the component picker able to dock as
>a side pane along the left or right of the schematic page view. I've
>re-layed out the dialog in a more vertical way, and removed the
>superfluous "Apply" and "Close" buttons.

	Okay.  I'd be curious to see this.

>
> * Split out component selection code from x_fileselect.c into a new
>file, x_compselect.c

	This is most certainly a good thing.	

>
> * Modified preview widget code to allow it to resize with available
>space

	Okay.

[snip]
> * First attempt at an icon for gschem ( from a photo of an 8pin SOIC ),
>mainly so I can identify which window is gschem easily in my "Alt-Tab"
>window switcher.

	People have been asking for this for a while now.

>
> * Code to set the icon is a bug hard-coded hack, and needs someone who
>knows how to assist in its proper implementation. (Getting automake /
>whatever to install the icon in the right place, and getting gschem to
>find it - rather than my hard-coded path method).

	Okay.

>
>Bugs noted:
>----------
>
> * Some odd behaviour I'm noticing when zooming the window after a
>resize, which can jump the mouse-pointer off the screen, put the
>schematic page origin in a funny place, allow components to be placed
>above the origin.

	Hmmm. Seems to work for me.  Could you describe the exact steps?

[snip]
>Any ideas on how to seperate these patched functionalities out, and
>which bits are suitable / useful for upstream inclusion?

	As mentioned before, I like small patches that I can apply.
That way, if necessary, I can add the logic to make the behavior
configurable.  As others, have indicated, a patch against CVS is 
always best.  Out of curiousity, are your changes against the old
noweb files or the new plain-c files?  Thanks.

								-Ales



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev