Re: gEDA-dev: gschem modifications

["Peter C.J. Clifton" <pcjc2-at-NOSPAMcam_dot_ac_dot_uk>]

>	Yes, this is definately preferable, as it is far far far easier
>for me to look at a patch that adds one feature.  I tend not to like
>monster patches since they are far hard to understand and verify.
>
>[snip]
>
>> * Added option to allow mouse panning on middle mouse button, as well
>>as RH button.
>
>	A change like this will most likely need to be configurable.	

Already is - will send patches before / during the code sprint tomorrow, as 
I'm away from my own computer.

I split out all the features into separate patches, and left 5 or 6 
versions of gschem compiling over night. When I'm back tomorrow, I'll test 
to make sure the patches are happy in isolation. (Although I know that my 
new component picker layout glitches the preview rendering without the 
seperate resizeable preview window patch)

>> * Changed pan "gain" to 1, rather than 5, so when panning with the
>>mouse, the schematic page moves as if you had actually grabbed the page
>>at the point when you start panning from
>
>	I'd be interested in playing with this change.

I think it feels more intuitive, ie.. panning in some graphics editors, 
acrobat viewer, others.. Is a one-line change, and is hardcoded for the 
moment. A "gain" could be a config parameter though if necessary.

>>We now have a gschem, where the mouse scroll wheel is able to zoom, pan
>>by dragging, and pan LR / UD by scrolling with modifier keys - basically
>>making it a navigation button / wheel.
>
>	This too might want to be configurable.  Another possibility is 
>to toss some of the configurability and just pick something and see
>what happens.  A benefit of this is that it is (I think?) more compatible
>with PCB.

I very much appreciate the "pick something which works" approach, but 
obviously gEDA has a seasoned user-base who will prefer their current way 
of working. I'd happily make it configurable if people prefer.

>> * Split out component selection code from x_fileselect.c into a new
>>file, x_compselect.c
>
>	This is most certainly a good thing.	

It will need someone's keen eye to see what bits of x_fileselect.c can now 
be removed. I've #if 0'd some functions out already. Is gschem actively 
trying to support the old GTK 1.X versions? If not, some of the code could 
be dropped in favour of the new GTK file-chooser version in the source.

>> * Some odd behaviour I'm noticing when zooming the window after a
>>resize, which can jump the mouse-pointer off the screen, put the
>>schematic page origin in a funny place, allow components to be placed
>>above the origin.
>
>	Hmmm. Seems to work for me.  Could you describe the exact steps?

I'll send more info tomorrow... I wrote down a sequence to reproduce on my 
computer. I recall it was when you make the aspect of the window more 
square than when the window started.. IE. shrink the window in the 
Left-right axis, then zoom fully out. Instead of the drawable page 
maintaining its previous aspect ratio, with a non-usable border top and/or 
bottom, it still allows you to place components on any visible portion of 
the screen. (Once zoomed in a little again, you cannot reach any components 
you placed outside the original page area using the scroll bars, only by 
zooming fully out again). - (OR SOME SUCH SIMILAR BEHAVIOUR)

	As mentioned before, I like small patches that I can apply.
>That way, if necessary, I can add the logic to make the behavior
>configurable.  As others, have indicated, a patch against CVS is 
>always best.  Out of curiousity, are your changes against the old
>noweb files or the new plain-c files?  Thanks.

Changes against the new plain-c files from the geda/gaf bit of CVS. Should 
be uptodate as of yesterday at about 5 or 6PM (GMT+1)

Many thanks,

Peter



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev