Re: gEDA-dev: [PATCH] gschem: Tidy up gtk_widget_show calls

[Peter TB Brett <peter-at-NOSPAMpeter-b_dot_co_dot_uk>]

On Wednesday 02 August 2006 19:48, Peter TB Brett wrote:
> In the x_window_create_main() function in gschem's x_window.c,
> gtk_widget_show() is called once for every component, while in fact the
> recursive function gtk_widget_show_all() could be called once at the end of
> the function.
>
> This patch is a tidying function: it attempts to make more easily
> understandable and maintainable code, but not to change any behaviour.

Actually, this patch introduces a noticeable improvement to gschem startup 
time.  I think that must be because each call to gtk_widget_show() fires off 
configure handlers and other event handlers for the widget, and thus has a 
fairly large overhead.

Peter

-- 
Fisher Society publicity officer            http://tinyurl.com/o39w2
CUSBC novices, match and league secretary   http://tinyurl.com/mwrc9
Quake II build tools maintainer             http://tinyurl.com/fkldd

v2sw6YShw7$ln5pr6ck3ma8u6/8Lw3+2m0l7Ci6e4+8t4Eb8Aen5+6g6Pa2Xs5MSr5p4
  hackerkey.com

PGP signature

_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev